Change ShutdownWorker err log from Debug to Warn#2195
Merged
yuandrew merged 2 commits intotemporalio:masterfrom Feb 17, 2026
Merged
Change ShutdownWorker err log from Debug to Warn#2195yuandrew merged 2 commits intotemporalio:masterfrom
yuandrew merged 2 commits intotemporalio:masterfrom
Conversation
cretz
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Change ShutdownWorker err log from Debug to Warn
Why?
Previously this RPC was sent only for sticky queue, but now that we have expanded the scope of this RPC message, there is more user-impact on its failure. The log here should be noisier, so users are more aware of its failure.
#2186 (comment)
Note
Low Risk
Only changes log severity for a shutdown-path RPC error; no functional behavior or data handling changes.
Overview
Updates worker shutdown logging to warn when the
ShutdownWorkerRPC fails (instead of debug), increasing visibility of shutdown notification failures while still ignoringUnimplementedresponses.Written by Cursor Bugbot for commit 4dbb691. This will update automatically on new commits. Configure here.